Hunting down this bug led me on a wild tangent which resulted in some small improvements for loading large directories in addition to fixing the even/odd bug. Funnily enough, I actually fixed an identical theme bug in genlist a few months ago.
A strong contender for EHotW, Sebastian Dransfeld has been fixing a considerable number of bugs over the past couple weeks. He’s a great guy who has been with the project for a very long time (the #3 entry in the E17 AUTHORS file!), so he definitely deserves more credit than these couple sentences give him. If you ever meet the guy, buy him a beer for me.
When loading an image preview, we try to get the image’s resolution to display. When loading an image preview that’s really an iso or some other non-image file, we end up mapping the entire file to memory and locking for a long time. Or at least we did until I fixed it.
After some deliberation, I decided on a method for allowing keyboard layout changes on desklock. It may or may not work, but at least I tried.
Other Improvements Today:
Video previews have been greatly improved both in layout and usability.